Skip to content

🐛Clusters-keeper: ensure json dicitionary is '-escaped #7564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2025
Merged

🐛Clusters-keeper: ensure json dicitionary is '-escaped #7564

merged 1 commit into from
Apr 23, 2025

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg commented Apr 23, 2025 •
edited
Loading

What do these changes do?

Related issue/s

fixes issue coming from #7485

How to test

Dev-ops checklist

@sanderegg sanderegg added this to the Pauwel Kwak milestone Apr 23, 2025
@sanderegg sanderegg self-assigned this Apr 23, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 23, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sanderegg sanderegg merged commit 9d0e894 into ITISFoundation:master Apr 23, 2025
50 checks passed
@sanderegg sanderegg deleted the clusters-keeper/fix-passing-autoscaling-rabbitmq-parameters branch April 23, 2025 09:11
@codecov
Copy link

codecov bot commented Apr 23, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.06%. Comparing base (3a72585) to head (0203bba).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (3a72585) and HEAD (0203bba). Click for more details.

HEAD has 29 uploads less than BASE
Flag BASE (3a72585) HEAD (0203bba)
unittests 30 1
Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #7564       +/-   ##
===========================================
- Coverage   87.61%   68.06%   -19.55%     
===========================================
  Files        1758      709     -1049     
  Lines       68132    33033    -35099     
  Branches     1124      170      -954     
===========================================
- Hits        59693    22484    -37209     
- Misses       8130    10491     +2361     
+ Partials      309       58      -251
Flag Coverage Δ
integrationtests 65.11% <ø> (-0.03%) ⬇️
unittests 99.25% <ø> (+12.44%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.24% <ø> (-8.16%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper 99.25% <ø> (-0.01%) ⬇️
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.36% <ø> (-13.01%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 89.08% <ø> (-1.04%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 59.15% <ø> (-26.93%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a72585...0203bba. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matusdrobuliak66 matusdrobuliak66 mentioned this pull request May 8, 2025
Closed
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcrespov pcrespov pcrespov left review comments

@YuryHrytsuk YuryHrytsuk Awaiting requested review from YuryHrytsuk

Assignees

@sanderegg sanderegg

Labels

a:clusters-keeper

Projects

None yet

Milestone

Pauwel Kwak

Development

Successfully merging this pull request may close these issues.

2 participants

@sanderegg @pcrespov